Elements: Add reference settings support #21601
Draft
+351
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraneto
force-pushed
the
v18/feature/element-reference-tracking
branch
from
1285e01 to
5d35055
Compare
…fications - Add DisableDeleteWhenReferenced check to ElementContainerService delete operations - Fire ElementDeletedNotification and EntityContainerDeletedNotification per item during descendant deletion - Fix potential infinite loop when items are skipped due to being referenced - Simplify EmptyRecycleBinAsync to use DeleteDescendantsLocked directly - Use path descending ordering for consistent deletion order (children before parents) - Add test for descendant delete notifications
…nced When DisableDeleteWhenReferenced is enabled and some items are skipped, the standard skip/take pagination breaks. This change: - Adds SqlLessThan/SqlGreaterThan SQL expression extensions for string comparison in LINQ queries - Uses path-based cursor pagination instead of skip/take - Tracks protected paths to prevent deleting containers that have referenced descendants - Adds ElementRecycleBin to UmbracoObjectTypes enum
Verify that DisableUnpublishWhenReferenced works correctly for elements (inherited from ContentPublishingServiceBase): - Cannot unpublish an element that is being referenced - Can unpublish an element that is doing the referencing
The Trashed filter was redundant because: - EmptyRecycleBinAsync only operates on items under the recycle bin root - DeleteFromRecycleBinAsync requires containers to be trashed, and all descendants are marked as trashed when moved to recycle bin Removing the filter simplifies the query and handles edge cases better.
lauraneto
force-pushed
the
v18/feature/element-reference-settings
branch
from
03b23fd to
c85ffbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DisableDeleteWhenReferencedsupport for elements when emptying recycle binEmptyRecycleBinwhen some items are skipped due to being referencedSqlLessThan/SqlGreaterThanSQL expression extensions for string comparison in LINQ queriesDisableUnpublishWhenReferencedworks for elements (inherited from base class)Changes
EmptyRecycleBin pagination fix
When
DisableDeleteWhenReferencedis enabled and some items are skipped, the standard skip/take pagination breaks. This change:ElementRecycleBintoUmbracoObjectTypesenumSQL expression extensions
SqlLessThanandSqlGreaterThanextension methods for string comparison in LINQ queries<and>operatorsTests
DisableDeleteWhenReferencedwith pagination across multiple pagesDisableUnpublishWhenReferencedfor elements