Skip to content

Fixed UmbracoMediaPickerConverter not working if value was Udi #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed UmbracoMediaPickerConverter not working if value was Udi #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions src/Umbraco.Cms.Integrations.Search.Algolia/Converters/UmbracoMediaPickerConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
{
public class UmbracoMediaPickerConverter : IAlgoliaIndexValueConverter
{
const string udiPrefix = "umb://media/";

private readonly IMediaService _mediaService;

public UmbracoMediaPickerConverter(IMediaService mediaService) => _mediaService = mediaService;
Expand All @@ -22,36 +24,37 @@ public object ParseIndexValues(IProperty property)
return list;
}

var inputMedia = JsonSerializer.Deserialize<IEnumerable<MediaItem>>(value);

if (inputMedia == null) return string.Empty;

foreach (var item in inputMedia)
if (value.StartsWith(udiPrefix))
{
if (item == null) continue;

var mediaItem = _mediaService.GetById(Guid.Parse(item.MediaKey));

if (mediaItem == null) continue;

list.Add(mediaItem.GetValue("umbracoFile")?.ToString() ?? string.Empty);
var guidPart = value.Substring(udiPrefix.Length);
if (Guid.TryParse(guidPart, out Guid guid))
{
var mediaItem = _mediaService.GetById(guid);
if (mediaItem != null)
{
list.Add(mediaItem.GetValue("umbracoFile")?.ToString() ?? string.Empty);
}
}
}
else
{
var inputMedia = JsonSerializer.Deserialize<IEnumerable<MediaItem>>(value);

return list;
}
if (inputMedia == null) return string.Empty;

private string ParseIndexValue(IEnumerable<object> values)
{
if (values != null && values.Any())
{
var value = values.FirstOrDefault();
foreach (var item in inputMedia)
{
if (item == null) continue;

var mediaItem = _mediaService.GetById(Guid.Parse(item.MediaKey));

if (value == null) return string.Empty;
if (mediaItem == null) continue;

return value.ToString();
list.Add(mediaItem.GetValue("umbracoFile")?.ToString() ?? string.Empty);
}
}

return string.Empty;
return list;
}
}
}