E2E: QA Added Umbraco.Test.Search.AcceptanceTest project with initial acceptance tests #70
Open
nhudinh0309 wants to merge 26 commits intomainfrom
Open
E2E: QA Added Umbraco.Test.Search.AcceptanceTest project with initial acceptance tests #70nhudinh0309 wants to merge 26 commits intomainfrom
nhudinh0309 wants to merge 26 commits intomainfrom
Conversation
…d copy uSync data
…reate .env file" step
0e9239d to
21653b4
Compare
andr317c
requested changes
Feb 16, 2026
| displayName: E2E Tests (SQLite) | ||
| pool: | ||
| vmImage: 'ubuntu-latest' | ||
| timeoutInMinutes: 30 |
| # Generate HTTPS dev certificate | ||
| - script: dotnet dev-certs https --trust | ||
| displayName: Generate HTTPS dev certificate | ||
| continueOnError: true |
| continueOnError: true | ||
|
|
||
| # Publish and run the test site | ||
| - script: dotnet publish src/Umbraco.Web.TestSite.V17/Umbraco.Web.TestSite.V17.csproj --configuration $(buildConfiguration) --output $(Build.ArtifactStagingDirectory)/testsite |
There was a problem hiding this comment.
Does this step not only publish it? It does not run anything
| - script: dotnet publish src/Umbraco.Web.TestSite.V17/Umbraco.Web.TestSite.V17.csproj --configuration $(buildConfiguration) --output $(Build.ArtifactStagingDirectory)/testsite | ||
| displayName: Publish test site | ||
|
|
||
| # Copy _uSync as sibling of testsite to match Development config path "../_uSync/Shared/" |
There was a problem hiding this comment.
What is meant with "as sibling of testsite"? Is it Copy uSync to be in the same path as the testsite?
Comment on lines
+415
to
+418
| # Install Playwright and dependencies | ||
| - pwsh: npx playwright install chromium | ||
| displayName: Install Playwright only with Chromium browser | ||
| workingDirectory: src/Umbraco.Test.Search.AcceptanceTest |
There was a problem hiding this comment.
We also install playwright at line 343
|
|
||
| await searchPage.expectResultCountGreaterThan(0); | ||
| }); | ||
|
|
| await searchPage.expectResultsForQuery('novel'); | ||
| await searchPage.expectResultCountGreaterThan(0); | ||
| }); | ||
|
|
| }); | ||
|
|
||
| test('displays pagination when results exceed page size', async () => { | ||
| const resultCount = await searchPage.getResultCount(); |
|
|
||
| test('can navigate to next page', async () => { | ||
| const resultCount = await searchPage.getResultCount(); | ||
| if (resultCount <= 5) { |
There was a problem hiding this comment.
If this ever is true, then this test is invalid.
|
|
||
| await searchPage.expectResultCountGreaterThan(0); | ||
| }); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Umbraco.Test.Search.AcceptanceTest) covering full-text search, facets, pagination, and sorting