Package copyrite in different ways #60
Conversation
…tes.io token for now, might change it later)
|
Well, I'll close the homebrew-core formula PR because
It'll have to be a separate homebrew tap for now. |
…t want to pollute TLD
…rated through cargo build --release
…ep outputs? We shall see...
…cker.com/build/building/multi-platform/... might need to adjust GHA args accordingly or are they automatically assigned?
.github/workflows/docker.yml
Outdated
| context: . | ||
| file: pkg/docker/Dockerfile | ||
| provenance: false | ||
| platforms: ${{ matrix.platforms }} |
There was a problem hiding this comment.
This should just a string like linux/amd64,linux/arm64.
Here's how I do this in the docker-who repo
There was a problem hiding this comment.
matrix is a GitHub action built-in for scattering / parallelising processes but you aren't actually scattering over anything?
There was a problem hiding this comment.
See https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations#adding-a-matrix-strategy-to-your-workflow-job for more information about matrices.
But I don't think you want that in this case, unless you want to actively resolve the separate architecture builds into a manifest yourself. Instead, I'd let the docker/build-push-action step do that for you.
There was a problem hiding this comment.
Also sorry, meant to just click 'comment' not 'approve'.
There was a problem hiding this comment.
Aaagh, gotcha. Ok, I'm not using matrix as I should, thanks, I'll try with a simple string, makes a ton of sense, otherwise it'd generate two docker images instead of one with multiple manifests!:
.github/workflows/docker.yml
Outdated
| context: . | ||
| file: pkg/docker/Dockerfile | ||
| provenance: false | ||
| platforms: ${{ matrix.platforms }} |
There was a problem hiding this comment.
matrix is a GitHub action built-in for scattering / parallelising processes but you aren't actually scattering over anything?
.github/workflows/docker.yml
Outdated
| context: . | ||
| file: pkg/docker/Dockerfile | ||
| provenance: false | ||
| platforms: ${{ matrix.platforms }} |
There was a problem hiding this comment.
See https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations#adding-a-matrix-strategy-to-your-workflow-job for more information about matrices.
But I don't think you want that in this case, unless you want to actively resolve the separate architecture builds into a manifest yourself. Instead, I'd let the docker/build-push-action step do that for you.
Fixes #11
Also: try to package on different fronts to facilitate distribution.