-
Notifications
You must be signed in to change notification settings - Fork 0
Mnv handling #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mnv handling #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for handling multi-base substitutions (MBS) alongside existing DBS/SNV/INDEL workflows and adjusts DBS handling to use predefined variant annotations. It also updates SNV plotting defaults and integrates MBS plotting and JSON export into the workflow.
- Add MBS counting, plotting, and JSON table export; integrate into sig_workflow_run
- Use predefined_dbs_mbs = TRUE when extracting DBS (and MBS) from VCF
- Update SNV rainfall default to FALSE and add logging for counting steps
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
File | Description |
---|---|
man/sig_workflow_run.Rd | Documents workflow function; adds predefined_dbs_mbs argument description but not reflected in usage/signature. |
man/sig_plot_snv.Rd | Updates function usage to include rainfall = FALSE and corrects default in docs. |
man/sig_plot_mbs.Rd | Adds docs for new sig_plot_mbs; output description appears inconsistent with code (list vs single plot). |
man/sig_mbs_table.Rd | Adds docs for new sig_mbs_table used for JSON export. |
man/sig_count_mbs.Rd | Adds docs for new sig_count_mbs; argument list/docs inconsistent with function signature/behavior. |
R/mutationalpatterns.R | Implements MBS count/plot/table; updates DBS counting to use predefined_dbs_mbs; integrates MBS into workflow and output; adds logging. |
NAMESPACE | Exports new MBS-related functions. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
See sash issue
Add
predefined_dbs_mbs = TRUE
, fordbs
typehandle
mbs
separately, with plot and table in case