Reworking the refactor page#1617
Open
AlexNetcare wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the way how a new location is being chosen when moving a page.
The reason for this change was that we had systems with so much test pages, that it took extremely long to open the refactor page since every page will be loaded for the autocomplete.
So a Solution to this was to create a tree structure where the children will be loaded lazily.
Since selecting the new location by clicking on a tree item, this would also prevent any User to select a non existing page.
The starting path for this refactoring is also configurable. For now I set the default to start at ROOT. If it would make sense to start at a different path, I can change that.
Also the starting point is selectable as well, unless it is ROOT.