Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commit messages are linted to follow the Conventional Config format, if they do not the commit fails. JavaScript and Vue files are linted before commiting, if they have linting warnings or errors the commit fails. Details of why a commit failed are logged in the console. README has been updated to include repo setup steps.
Dependencies
husky
commitlint
and@commitlint/config-conventional
Technical Details
Linting JS and Vue files has been implemented in the
site
package only. Further discussion is needed to determine how to handle linting inzero-core
and I don't want to mess withdocs
while it's still being set up but it should follow the same pattern assite
.Resolutions