fix: require pagination formset class for paginated inlines #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviyadeveloper
force-pushed
the
require_paginated_formsets_for_paginated_inlines
branch
from
2d6e3dc to
f3be146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces that the class of a formset given to a paginated inline (determined by an inline having the
per_pageprop) is eitherPaginationInlineFormSetorPaginationGenericInlineFormSetto avoid users passing the default base django admin formset classes.Note:
Current behavior still breaks but with an explicit error and explanation how to fix the issue. This is done because simply skipping would lead to no pagination and probable confusion by the user.
fixes: #1402