Skip to content

Revert "glib_compat/glib_compact: Clear the buffer in g_hash_table_resize" - #2220

Merged
wtdcode merged 1 commit into
devfrom
revert-2219-dev
Aug 30, 2025
Merged

Revert "glib_compat/glib_compact: Clear the buffer in g_hash_table_resize"#2220
wtdcode merged 1 commit into
devfrom
revert-2219-dev

Conversation

@wtdcode

@wtdcode wtdcode commented Jul 28, 2025

Copy link
Copy Markdown
Member

Reverts #2219

As requested by @PhilippTakacs , this fix might be redundant.

@PhilippTakacs

Copy link
Copy Markdown
Contributor

As already explained: the g_new0 function returns already clean memory. This is also required, because when new_nodes wouldn't be all zero the hashtable wouldn't work correct after resize.

For the failed test I would guess this is because of a to low timeout.

@wtdcode

wtdcode commented Aug 30, 2025

Copy link
Copy Markdown
Member Author

Confirmed that it is backend by calloc.

My bad, sorry.

@wtdcode
wtdcode merged commit 443aa98 into dev Aug 30, 2025
95 of 96 checks passed
K4ddate pushed a commit to K4ddate/unicorn that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants