riscv: gate fsgnj.d/fmv.d on FPU and D extension - #2393
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
carlosqwqqwq
force-pushed
the
fix/riscv-fsgnj-d-ext-gate
branch
from
August 29, 2026 07:24
ead4b4b to
c61a607
Compare
Author
|
Thank you very much for taking the time to review this PR. We have rebased it onto dev, added the required feature checks, and added focused coverage for an RV64 CPU without the D extension. Could you please let us know what further code, test, or PR changes you would recommend? We will gladly adjust the patch to match the project guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2388
Problem
trans_fsgnj_dlacksREQUIRE_FPUandREQUIRE_EXT(ctx, RVD), sofsgnj.d/fmv.dretire on CPU models without F/D (e.g. SiFive E51) instead of raising an illegal-instruction trap.Change
qemu/target/riscv/insn_trans/trans_rvd.inc.ctrans_fsgnj_d: addREQUIRE_FPU; REQUIRE_EXT(ctx, RVD);at the top, matching every other D-extension translation in the same file.The focused unit test is test_riscv64_fsgnj_d_cpu_feature in tests/unit/test_riscv.c; the public u020 runner is linked below.
Validation
dev.tests/unit/test_riscv.c.Public reproducer:
https://github.com/carlosqwqqwq/unicorn-riscv-repros/tree/main/u020