Optimization and more tests - #2410
Closed
Nitr0-G wants to merge 4 commits into
Closed
Conversation
wtdcode
reviewed
Aug 31, 2026
| name: ${{ matrix.config.artifact }} | ||
| compression-level: 0 | ||
|
|
||
| - name: '📤 Retry artifact upload' |
Member
There was a problem hiding this comment.
This seems werid, what's the reason?
wtdcode
reviewed
Aug 31, 2026
| compression-level: 0 | ||
| overwrite: true | ||
|
|
||
| PythonRegressions: |
Member
There was a problem hiding this comment.
This workflow is not necessary. We will finally move Python out.
wtdcode
reviewed
Aug 31, 2026
|
|
||
| - name: 'Bootstrap Alpine apk-tools' | ||
| shell: bash | ||
| env: |
Member
There was a problem hiding this comment.
This looks too hacky and I'm afraid it is not correct to fix a version.
wtdcode
reviewed
Aug 31, 2026
| reg_write_t write; | ||
| } context_reg_rw_t; | ||
|
|
||
| typedef struct UcEmuFrame { |
Member
There was a problem hiding this comment.
Wait, what's rationale of these changes?
Member
|
The regression tests are not necessary to fix and that cuases the diff hard to review. |
Author
|
As discussed - I close it, break it down into different prs and merge them stage by stage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimization and more tests