Fix type hints of pa.Field so Iterable and dict arguments actually contain type information #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfandringa
force-pushed
the
bugfix/1899
branch
from
4a4da66 to
2a96a75
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 94.28% 93.32% -0.96%
==========================================
Files 91 121 +30
Lines 7013 9303 +2290
==========================================
+ Hits 6612 8682 +2070
- Misses 401 621 +220 ☔ View full report in Codecov by Sentry. |
…ntain type information Signed-off-by: Dolf Andringa <[email protected]>
dolfandringa
force-pushed
the
bugfix/1899
branch
from
2a96a75 to
a7fe3c9
Compare
|
I fixed the linting issue in python 3.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1899 by specifying more complete type hints for
pandera.Field. The fix is not very specific, but aims to at least pass strict type checking with pyright.