fix: allow sharp, esbuild and turbo build scripts - #319
Merged
Conversation
pnpm blocks dependency build scripts by default and this workspace declared no
`onlyBuiltDependencies`, so sharp's install script never runs. On Linux that goes
unnoticed - a matching prebuilt binary arrives as an optional dependency - but on
macOS `astro build` fails:
MissingSharp: Could not find Sharp. Please install Sharp (`sharp`) manually
into your project or migrate to another image service.
This is why the sharp security PR (#309) could not pass its macOS CI leg. Proven
there: the same change on that branch turned the run green.
Fixing it on `main` rather than only on that branch, because the missing
declaration is a property of this repo, not of the sharp upgrade - any dependency
PR touching these packages hits it, and Renovate will inherit the fix when it
rebases.
esbuild and turbo are native installers in the same position; pnpm reports all
three as ignored.
Verified: `pnpm install --frozen-lockfile` no longer warns about ignored builds
and `pnpm run verify` exits 0, 4/4 tasks.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ETjy9oQGyETyFmDBdR9Egz
Signed-off-by: unional <homawong@gmail.com>
|
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm blocks dependency build scripts by default, and this workspace declared no
onlyBuiltDependenciesat all. So sharp's install script never runs.On Linux that goes unnoticed — a matching prebuilt binary arrives as an optional dependency. On macOS
astro buildfails:That is why the sharp security PR #309 could not pass its macOS leg. The same change applied to that branch turned its run green, which is the evidence this is the right fix.
Why this belongs on
main, not on that PRThe missing declaration is a property of this repo, not of the sharp upgrade. Any dependency PR that touches these packages hits it, and #309 conflicted with
mainafter #310 landed. Fixing it here means Renovate inherits it on its next rebase instead of each PR carrying the same patch.esbuildandturboare native installers in the same position — pnpm reports all three as ignored, so they are declared together.Verified
The macOS-only failure cannot be reproduced on Linux, so CI is the real check here — as it was on #309, where it passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ETjy9oQGyETyFmDBdR9Egz