Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(voyager): ensure_ibc_interface supports multiple interfaces #3578

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kayandra
Copy link

@kayandra kayandra commented Jan 18, 2025

Allow checking an interface against multiple expected values by taking a Vec of interfaces.

Updates error type to show all valid interfaces in error message.

Ref #3438

Copy link

vercel bot commented Jan 18, 2025

@kayandra is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

@kayandra kayandra changed the title refactor(voyager): support multiple IBC interfaces in ensure_ibc_interface refactor(voyager): ensure_ibc_interface supports multiple interfaces Jan 18, 2025
lib/voyager-message/src/module.rs Outdated Show resolved Hide resolved
voyager/modules/client/ethereum/src/main.rs Outdated Show resolved Hide resolved
voyager/modules/client/movement/src/main.rs Outdated Show resolved Hide resolved
voyager/modules/client/state-lens/ics23-ics23/src/main.rs Outdated Show resolved Hide resolved
voyager/modules/client/state-lens/ics23-mpt/src/main.rs Outdated Show resolved Hide resolved
cosmwasm/ucs00-pingpong/src/ibc.rs Show resolved Hide resolved
lib/voyager-message/src/module.rs Outdated Show resolved Hide resolved
@ladyoxford

This comment was marked as spam.

Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise lgtm!

lib/voyager-message/src/module.rs Outdated Show resolved Hide resolved
@kayandra kayandra marked this pull request as ready for review January 28, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants