WIP: Vala #2320

albfan · 2019-11-13T08:00:07Z

Work in progress for vala parser.

Written from scratch.

Right now is just a plain copy/paste from tcl parser

relates to #621

coveralls · 2019-11-13T08:59:01Z

Coverage increased (+0.04%) to 86.407% when pulling 7692199 on albfan:vala into 2ebf5b1 on universal-ctags:master.

albfan · 2019-11-16T14:06:27Z

I think this is a wrong way to approach the implementation.

albfan · 2019-11-16T18:34:43Z

Reopening this as is the only acceptable approach to include vala into ctags.

codecov-io · 2019-11-16T18:42:34Z

Codecov Report

Merging #2320 into master will increase coverage by 0.03%.
The diff coverage is 92.64%.

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
+ Coverage   86.25%   86.29%   +0.03%     
==========================================
  Files         176      177       +1     
  Lines       35717    35921     +204     
==========================================
+ Hits        30808    30997     +189     
- Misses       4909     4924      +15

Impacted Files	Coverage Δ
parsers/vala.c	`92.64% <92.64%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebf5b1...e45ea24. Read the comment docs.

/* * Vala Hello World */ void main(string[] args) { print("Hello, World\n"); } [jet@living]~/var/ctags% ./ctags -o - /tmp/foo.vala main /tmp/foo.vala /^void main(string[] args) {$/;" m

parsers/vala.c

albfan · 2019-12-02T14:53:06Z

@masatake I have first question on this parsers:

How to detect a vala field (inside a class) and a property (field with get and set:

class Address {
   public string street; 
   ...
}

class Person {
   public Address address;
   public string name {get; set;}
   ...
}

Understanding this seems the key to me. (maybe I should reread the links you suggest right now?)

masatake · 2019-12-02T16:53:11Z

How to detect a vala field (inside a class) and a property (field with get and set:

Please show the pair of "input.vala" and "exepected.tags". The pair is very important for me to understand what you need. If you cannot image "expected.tags" for the input, I cannot help you. In that case, what you have to do is reading ctags(1) man page carefully.

Units/parser-vala.r/class.vala.b/expected.tags

albfan · 2019-12-02T17:14:10Z

I added a review comment in expected.ctags that will be my approach to reimplement this, and once I see how to understand the scope for a tag (things inside a pair) things that depends on several previous tokens I will figure out myself the rest.

Thanks for help here!

masatake · 2019-12-02T17:49:31Z

I promised @k-takata I will focus on releasing related work till we can find a long term volunteer who drives the documentation related work of this project.

So I will show only sample code. I hope it helps you.
Ideally, I should consider the work of your side.

$ cat foo.vala void main(string[] args) { print("Hello, World\n"); } class Address { public string street; } $ ./ctags -o - ./foo.vala ./ctags -o - ./foo.vala Address ./foo.vala /^class Address {$/;" c language:Vala main ./foo.vala /^void main(string[] args) {$/;" m language:Vala

$ cat foo.vala void main(string[] args) { print("Hello, World\n"); } class Address { public string street; int floor; } $ ./ctags -o - --fields=+a ./foo.vala ./ctags -o - --fields=+a ./foo.vala Address ./foo.vala /^class Address {$/;" c language:Vala floor ./foo.vala /^ int floor; $/;" f language:Vala class:Address typeref:unknown:int main ./foo.vala /^void main(string[] args) {$/;" m language:Vala street ./foo.vala /^ public string street;$/;" f language:Vala class:Address typeref:typename:string access:public Signed-off-by: Masatake YAMATO <[email protected]>

$ cat foo.vala void main(string[] args) { print("Hello, World\n"); } class Address { public string street; int floor; } class Person { public Address address; public string name {get; set;} } $ ./ctags --sort=no -o - --fields=+a ./foo.vala main ./foo.vala /^void main(string[] args) {$/;" m language:Vala Address ./foo.vala /^class Address {$/;" c language:Vala street ./foo.vala /^ public string street;$/;" f language:Vala class:Address typeref:typename:string access:public floor ./foo.vala /^ int floor; $/;" f language:Vala class:Address typeref:unknown:int Person ./foo.vala /^class Person {$/;" c language:Vala address ./foo.vala /^ public Address address;$/;" f language:Vala class:Person typeref:unknown:Address access:public name ./foo.vala /^ public string name {get; set;}$/;" p language:Vala class:Person typeref:typename:string access:public

masatake · 2019-12-02T19:18:54Z

See #621. I updated my branch.

albfan · 2019-12-02T23:05:37Z

@masatake I think I get it. I rebase this on top of your branch (I rebased on top of master too.

parseClassBody is really helpful. Let's see if I can complete the rest on my own.

* tokenCat * tokenLast Signed-off-by: Masatake YAMATO <[email protected]>

…eninfo Signed-off-by: Masatake YAMATO <[email protected]>

$ cat /tmp/foo.vala class Person { public Data.Address address; } $ ./ctags -o - /tmp/foo.vala Person /tmp/foo.vala /^class Person {$/;" c address /tmp/foo.vala /^ public Data.Address address;$/;" f class:Person typeref:class:Data.Address

$ cat /tmp/foo.vala /* * Vala Hello World */ void main(string[] args) { print("Hello, World\n"); $ ./ctags -o - --fields=+S /tmp/foo.vala main /tmp/foo.vala /^void main(string[] args) {$/;" m signature:(string [] args)

$ cat /tmp/foo.vala void main(string[] args) { print("Hello, World\n"); } class Address { public string street; int floor; } class Person { public Address address; public string name {get; set;} } $ ./ctags -o - --sort=no --extras=+q /tmp/foo.vala main /tmp/foo.vala /^ void main(string[] args) {$/;" m language:Vala Address /tmp/foo.vala /^ class Address {$/;" c language:Vala street /tmp/foo.vala /^ public string street;$/;" f language:Vala class:Address typeref:typename:string Address.street /tmp/foo.vala /^ public string street;$/;" f language:Vala class:Address typeref:typename:string floor /tmp/foo.vala /^ int floor;$/;" f language:Vala class:Address typeref:unknown:int Address.floor /tmp/foo.vala /^ int floor;$/;" f language:Vala class:Address typeref:unknown:int Person /tmp/foo.vala /^ class Person {$/;" c language:Vala address /tmp/foo.vala /^ public Address address;$/;" f language:Vala class:Person typeref:unknown:Address Person.address /tmp/foo.vala /^ public Address address;$/;" f language:Vala class:Person typeref:unknown:Address name /tmp/foo.vala /^ public string name {get; set;}$/;" p language:Vala class:Person typeref:typename:string Person.name /tmp/foo.vala /^ public string name {get; set;}$/;" p language:Vala class:Person typeref:typename:string

if, while, for shouldn't be detected as methods

albfan · 2019-12-08T12:00:20Z

Closing in favor of masatake#6 where the development is really happening

albfan mentioned this pull request Nov 13, 2019

Merge support for the Vala language #621

Open

albfan force-pushed the vala branch from 5c01282 to 6bb9d60 Compare November 13, 2019 08:53

albfan force-pushed the vala branch 8 times, most recently from edac74d to d4c1fc3 Compare November 15, 2019 15:43

albfan closed this Nov 16, 2019

albfan reopened this Nov 16, 2019

[jet@living]~/var/ctags% cat /tmp/foo.vala

a9dd376

/* * Vala Hello World */ void main(string[] args) { print("Hello, World\n"); } [jet@living]~/var/ctags% ./ctags -o - /tmp/foo.vala main /tmp/foo.vala /^void main(string[] args) {$/;" m

albfan force-pushed the vala branch 5 times, most recently from 7e823e8 to 1b1b9eb Compare December 1, 2019 11:00

k-takata reviewed Dec 2, 2019

View reviewed changes

parsers/vala.c Outdated Show resolved Hide resolved

albfan force-pushed the vala branch 3 times, most recently from f405135 to 538a597 Compare December 2, 2019 14:48

albfan commented Dec 2, 2019

View reviewed changes

Units/parser-vala.r/class.vala.b/expected.tags Outdated Show resolved Hide resolved

masatake added 5 commits December 3, 2019 02:56

Vala: turn on cork

0461a51

Vala: skip newline characters when reading a token

1424072

albfan force-pushed the vala branch from 538a597 to b18199b Compare December 2, 2019 22:42

masatake added 4 commits December 5, 2019 11:33

main: add helper macros to manipulate and access vString in tokeninfo

ceb2516

* tokenCat * tokenLast Signed-off-by: Masatake YAMATO <[email protected]>

main: add tokenIsTypeVal, a helper macro for checking the type of tok…

37fc8db

…eninfo Signed-off-by: Masatake YAMATO <[email protected]>

Vala: fill signature field of methods

9b9efc3

$ cat /tmp/foo.vala /* * Vala Hello World */ void main(string[] args) { print("Hello, World\n"); $ ./ctags -o - --fields=+S /tmp/foo.vala main /tmp/foo.vala /^void main(string[] args) {$/;" m signature:(string [] args)

albfan force-pushed the vala branch from 9c6fda8 to 705f425 Compare December 5, 2019 19:35

albfan force-pushed the vala branch 3 times, most recently from 4d2f4ed to 1c3b2ad Compare December 7, 2019 06:37

albfan added 7 commits December 8, 2019 11:45

Add vala to windows compilation

05d3e3d

Reorder ValaParser

3495833

Fix copyright for ValaParser

6daa4a1

Add test suite for Vala

5bc7dba

Include vala keywords

1ae79ac

Avoid statement tags for simple statements

3cce12e

if, while, for shouldn't be detected as methods

Parsing namespaces

e45ea24

albfan force-pushed the vala branch from 1c3b2ad to e45ea24 Compare December 8, 2019 11:46

fix typo in variable

7692199

albfan closed this Dec 8, 2019

masatake mentioned this pull request Oct 8, 2020

Complete vala parser masatake/ctags#6

Closed

WIP: Vala #2320

WIP: Vala #2320

Uh oh!

Conversation

albfan commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

albfan commented Nov 16, 2019

Uh oh!

albfan commented Nov 16, 2019

Uh oh!

codecov-io commented Nov 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

albfan commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

masatake commented Dec 2, 2019

Uh oh!

Uh oh!

albfan commented Dec 2, 2019

Uh oh!

masatake commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

masatake commented Dec 2, 2019

Uh oh!

albfan commented Dec 2, 2019

Uh oh!

albfan commented Dec 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

albfan commented Nov 13, 2019 •

edited

Loading

coveralls commented Nov 13, 2019 •

edited

Loading

codecov-io commented Nov 16, 2019 •

edited

Loading

albfan commented Dec 2, 2019 •

edited

Loading

masatake commented Dec 2, 2019 •

edited

Loading