Skip to content

Conversation

@masatake
Copy link
Member

@masatake masatake commented Jan 29, 2022

See #3284.

This change is based on the pull request universal-ctags#3276 submitted by Glog78.
@masatake
Copy link
Member Author

@Glog78, I could not make a decision about the way for tagging aliases.
This change just extracts declarations as reference tags.

This change is based on the pull request universal-ctags#3276 submitted by @Glog78.

Signed-off-by: Masatake YAMATO <[email protected]>
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #3289 (a503ac7) into master (e00b662) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3289   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         210      210           
  Lines       49783    49793   +10     
=======================================
+ Hits        42437    42447   +10     
  Misses       7346     7346           
Impacted Files Coverage Δ
parsers/basic.c 98.87% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00b662...a503ac7. Read the comment docs.

@masatake
Copy link
Member Author

masatake commented Feb 2, 2022

@Glog78, this pull request is acceptable?

For trying this pull request, see the instructions in https://docs.ctags.io/en/latest/contributions.html#testing-a-pr-locally-before-being-merged .

@Glog78
Copy link
Contributor

Glog78 commented Feb 3, 2022

@masatake will check during the weekend ... sorry i am busy with a work related project

@masatake
Copy link
Member Author

masatake commented Feb 4, 2022

@masatake will check during the weekend ... sorry i am busy with a work related project

No problem. Thank you for taking your time for improving ctags.

@Glog78
Copy link
Contributor

Glog78 commented Feb 5, 2022

ok i found quiet a few interesting things....

a.) ptr does count as keyword ? -> https://documentation.help/FreeBASIC/KeyPgPtr.html
b.) i have a variable called subwin :) i guess you should see the result

i guess we aren't there yet ...

https://github.com/Glog78/freebasic_example
^^ example project
https://github.com/quangnguyen30192/cmp-nvim-tags
^^ the completion plugin i use to use tags

@masatake
Copy link
Member Author

masatake commented Feb 5, 2022

ok i found quiet a few interesting things....

a.) ptr does count as keyword ? -> https://documentation.help/FreeBASIC/KeyPgPtr.html

I don't understand this one well.
Do you say whether our parser deals ptr as a keyword or not changes the output of ctags?

b.) i have a variable called subwin :) i guess you should see the result

I don't understand this one well.

 		declare	function	CreateSubWindow alias "subwin" (byval as win ptr, byval as integer, byval as integer, byval as integer, byval as integer) as win ptr

Are you taking about "subwin" in this line?

After thinking again and again, I cannot find a good way to deal with aliases because we cannot say whether an alias is a definition or reference. So in this pull request, I don't touch these aliases.

@Glog78
Copy link
Contributor

Glog78 commented Feb 5, 2022

forget my comment ... i was using an old tags file for some reason
the current created tags file looks clean to me 👍
again sorry for making you nervous

@Glog78
Copy link
Contributor

Glog78 commented Feb 5, 2022

One question shouldn't be the variables from type _win_st (any other type for this matter too) somehow connected to this type ?
currently they are only connected to the namespace if i see it correctly

like you would want to write
dim test as curses.curses_priv._win_st
test._notimeout ....

@masatake
Copy link
Member Author

masatake commented Feb 5, 2022

Could you use GitHUb's markdown notation like:

_win_st

or _win_st

It helps me to understand your sentences. Sorry for the inconvenience.

@masatake
Copy link
Member Author

@Glog78, do you think we can merge this?

@Glog78
Copy link
Contributor

Glog78 commented Feb 13, 2022

We improved the current situation, so and i am not aware that we broke anything which worked before. So yeah i would guess we could merge, even as you noted there is parts missing.

@masatake
Copy link
Member Author

masatake commented Feb 14, 2022

i am not aware that we broke anything which worked before.

I would like to hear more about this. I guess what you wrote is something to do with your comment:

One question shouldn't be the variables from type _win_st (any other type for this matter too) somehow connected to this type ?
currently they are only connected to the namespace if i see it correctly

like you would want to write
dim test as curses.curses_priv._win_st
test._notimeout ....

I didn't understand this one well.
Were you writing about filling typeref field?

@masatake masatake merged commit a6f4f47 into universal-ctags:master Mar 5, 2022
@masatake
Copy link
Member Author

masatake commented Mar 5, 2022

@Glog78, feel free to open an issue for the topic you mentioned in the comments.

@masatake masatake deleted the basic--decl branch March 5, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants