-
Notifications
You must be signed in to change notification settings - Fork 647
Basic: extract declarations as reference tags (partially derived from #3276) #3289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change is based on the pull request universal-ctags#3276 submitted by Glog78.
|
@Glog78, I could not make a decision about the way for tagging aliases. |
This change is based on the pull request universal-ctags#3276 submitted by @Glog78. Signed-off-by: Masatake YAMATO <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3289 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 210 210
Lines 49783 49793 +10
=======================================
+ Hits 42437 42447 +10
Misses 7346 7346
Continue to review full report at Codecov.
|
|
@Glog78, this pull request is acceptable? For trying this pull request, see the instructions in https://docs.ctags.io/en/latest/contributions.html#testing-a-pr-locally-before-being-merged . |
|
@masatake will check during the weekend ... sorry i am busy with a work related project |
No problem. Thank you for taking your time for improving ctags. |
|
ok i found quiet a few interesting things.... a.) ptr does count as keyword ? -> https://documentation.help/FreeBASIC/KeyPgPtr.html i guess we aren't there yet ... https://github.com/Glog78/freebasic_example |
I don't understand this one well. b.) i have a variable called subwin :) i guess you should see the result I don't understand this one well. Are you taking about After thinking again and again, I cannot find a good way to deal with aliases because we cannot say whether an alias is a definition or reference. So in this pull request, I don't touch these aliases. |
|
forget my comment ... i was using an old tags file for some reason |
|
One question shouldn't be the variables from type _win_st (any other type for this matter too) somehow connected to this type ? like you would want to write |
|
Could you use GitHUb's markdown notation like: or It helps me to understand your sentences. Sorry for the inconvenience. |
|
@Glog78, do you think we can merge this? |
|
We improved the current situation, so and i am not aware that we broke anything which worked before. So yeah i would guess we could merge, even as you noted there is parts missing. |
I would like to hear more about this. I guess what you wrote is something to do with your comment:
I didn't understand this one well. |
|
@Glog78, feel free to open an issue for the topic you mentioned in the comments. |
See #3284.