Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: extract reference tags #3579

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

masatake
Copy link
Member

@masatake masatake commented Dec 5, 2022

No description provided.

@masatake masatake changed the title Python: reference tags Python: extract reference tags Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (293f11e) 85.32% compared to head (3ffd74b) 85.35%.
Report is 49 commits behind head on master.

Files Patch % Lines
parsers/python.c 97.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3579      +/-   ##
==========================================
+ Coverage   85.32%   85.35%   +0.02%     
==========================================
  Files         231      231              
  Lines       55732    55853     +121     
==========================================
+ Hits        47555    47675     +120     
- Misses       8177     8178       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake
Copy link
Member Author

I must redefine the semantics of the scope field:

def foo():
    a.b()

In this case, for the reference tag b, how the scope filed should be: scope:foo or scope:a. I got the hint about this from @pragmaware ago. I must re-read his comment, and I must document it in "the reference tag design guide" or something.

As @AmaiKinono suggested, there are two types of reference tags: dependency reference tags and generic reference tags. The former one should be enabled by default. The latter one would be disabled by default. This also should be written in the guide.

@masatake
Copy link
Member Author

Versioning and updating the man page for Python are needed for merging.

@masatake masatake added this to the 6.2 milestone Dec 28, 2023
@masatake masatake modified the milestones: 6.2, 7.0 Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant