Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: handle spread syntax #3846

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

masatake
Copy link
Member

@masatake masatake commented Nov 16, 2023

Related to #3435.


JavaScript: handle spread syntax

With this change, the parser skip "..." and the subsequent expression.

ref. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5aa12d) 85.02% compared to head (014fbcd) 85.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3846   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files         228      228           
  Lines       53897    53900    +3     
=======================================
+ Hits        45828    45831    +3     
  Misses       8069     8069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake
Copy link
Member Author

I must add a reference to a page describing the spread operator.

@masatake masatake marked this pull request as draft November 16, 2023 21:52
@leleliu008
Copy link
Member

leleliu008 commented Nov 16, 2023

@masatake our GitHub Actions BSD workflows alwasy fail these days. I have no idea how to fix it. The only way is waiting GitHub Actions Team's fix. Reference: actions/runner-images#8730

@masatake
Copy link
Member Author

@leleliu008 Thank you. Could you make a "temporarily disabling" pull request and merge it?

@leleliu008
Copy link
Member

@leleliu008 Thank you. Could you make a "temporarily disabling" pull request and merge it?

Done via #3848

@masatake masatake marked this pull request as ready for review November 17, 2023 04:52
@masatake
Copy link
Member Author

It seems that "spread operator" is a term in TypeScript.
After reading https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax, "spread syntax" is the term I should use here.

With this change, the parser skip "..." and the subsequent expression.

ref. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax

Related to universal-ctags#3435.

Signed-off-by: Masatake YAMATO <[email protected]>
@masatake masatake changed the title JavaScript: skip spread operators JavaScript: handle spread syntax Nov 17, 2023
@masatake masatake merged commit f727e74 into universal-ctags:master Nov 17, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants