Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aliases for the new "official" fork eza instead of exa #277

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

neiromaster
Copy link
Contributor

@neiromaster neiromaster commented Oct 3, 2023

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Added eza check and alias generation taking into account the installed application - exa or eza

Description

In the official Exa repository it says to use the new Eza fork now. In this PR I check if eza is available and if it is not, I check if exa is installed. Then the correct aliases are formed with the correct application.

I also noticed that the environment variable EXA_TREE_IGNORE is not used in either exa or eza. I kept the environment variable, but changed its name to a more neutral one and passed its value explicitly to the tree alias call.

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates
  • Test updates
  • Bug fix
  • New feature
  • Plugin list change

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the readme if this PR changes/updates quickstart functionality.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.

@codeclimate
Copy link

codeclimate bot commented Oct 3, 2023

Code Climate has analyzed commit c51e6b9 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Thanks for the update, I hadn't seen that the preferred method is now eza.

@unixorn unixorn merged commit 9c31f27 into unixorn:main Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants