Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'fzf' installation instructions in Readme #290

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

neiromaster
Copy link
Contributor

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Description

The commit adds more detailed steps for the installation and configuration of 'fzf'. It specifies the exact commands to be run and provides guidance on the prompts users might encounter, improving clarity for users unfamiliar with the process. Resolves #286

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates
  • Test updates
  • Bug fix
  • New feature
  • Plugin list change

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the readme if this PR changes/updates quickstart functionality.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.

The commit adds more detailed steps for the installation and configuration of 'fzf'. It specifies the exact commands to be run and provides guidance on the prompts users might encounter, improving clarity for users unfamiliar with the process.
Changed the shell used in the `fzf` configuration command in the Readme.md file. Previously instructed to use `zsh`, but it was changed to `sh` to ensure wider compatibility.
Copy link

codeclimate bot commented Apr 12, 2024

Code Climate has analyzed commit db2c0a5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@unixorn unixorn added the documentation Documentation changes label Apr 12, 2024
@unixorn unixorn merged commit 49f6f48 into unixorn:main Apr 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FZF_PATH variable not pointing to FZF installed with Brew
2 participants