test: enforce 100% coverage - #49
Merged
Merged
Conversation
📊 Coverage Analysis Report
✅ All files meet the target coverage of 100%! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pragma: no cover.Why
The package had 306 uncovered statements at the initial measurement and the coverage workflow still targeted the old
pykispackage at a 70% threshold. The new tests exercise the actual behavior and the CI configuration now measures the currentkis_agentpackage consistently.Validation
pytest tests/ --cov=kis_agent --cov-fail-under=100 --cov-report=json:/tmp/kis-agent-coverage-workflow.json --cov-report=term-missing:skip-covered -q --tb=no2084 passed, 89 skipped9974 / 9974statements covered,100.00%, 0 missinggit diff --checkpassed.OpenSwarm review
OpenSwarm returned
REVISE. Its valid findings aboutpragma: no cover, incomplete untracked-test visibility, import ordering, and missing endpoint assertions were addressed. The final review's claimed--cov-fail-undtypo is a false positive: the committed workflow contains the valid--cov-fail-under="${TARGET_COVERAGE}"option. The exact workflow-equivalent command above passes locally at 100%.