Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: #815 shadcn-nuxt dependencies and CLI init #821

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

selemondev
Copy link
Contributor

Closes: #815

πŸ”— Linked issue

This pull request is intended to close issue number #815

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This pull request intends to do two things namely:

  1. Refactor the Shadcn Vue CLI: Before this PR, the PROJECT_DEPENDENCIES object had two properties namely: base and nuxt but now it only has the base as its property. In the base array we have 5 dependencies that get installed when initializing the Shadcn Vue CLI as long as the framework selected is not Nuxt. In the nuxt array we only had the @nuxtjs/tailwindcss module which got installed if you selected nuxt as your preferred framework but this doesn't look right because we could install this alongside the shadcn-nuxt module allowing for separation of concerns. This PR intends to fix this issue by allowing the dependencies in the base array to be installed in all the frameworks including Nuxt because the issue raised here states that the shadcn-nuxt module doesn't install any dependencies. This PR intends to fix that.
  2. Refactor the shadcn-nuxt module: This PR intends to refactor the shadcn-nuxt module by installing the required modules ( @nuxtjs/color-mode and @nuxtjs/tailwindcss ) and thus allows for the separation of concerns between the module and the CLI. In simple terms, the CLI handles general functionalities while the module ( shadcn-nuxt ) handles specific functionalities related to Nuxt.

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
Copy link
Collaborator

@zernonia Hi, since you gonna work on the new CLI, please review this PR, Thanks

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @selemondev !

@zernonia zernonia merged commit 3646203 into unovue:dev Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: shadcn-nuxt doesnt install any dependency
3 participants