Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: switch from placeholder: to data-placeholder: prefix class for SelectValue #867

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

damienroche
Copy link
Contributor

@damienroche damienroche commented Nov 5, 2024

πŸ”— Linked issue

close #866

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

On radix-vue docs, placeholder is set by using [data-placeholder] attribute. To apply style, we need to use data-[placeholder]: prefix class instead of placeholder: prefix which is used only for input type

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati sadeghbarati merged commit a5b25a9 into unovue:dev Nov 9, 2024
1 check passed
@sadeghbarati
Copy link
Collaborator

Thanks ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Placeholder class on select not working
2 participants