Repository navigation
Conversation
Currently we detect this deep in `DependencyValues`, but we can localize it in `prepareDependencies` instead and avoid potential preview crashes.
…reeco#413) * Support @dependency property wrapper cast to a concrete type. * better fatal errors * wip * clean up * wip --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com>
* General cleanup: Dependency, CurrentDependency * SwiftUI Environment compatibility * wip
... like swift-distributed-tracing [did](https://github.com/apple/swift-distributed-tracing/pull/175/changes)
diederich
force-pushed
the
bugfix/wasm-build
branch
from
March 10, 2026 20:45
bb3a0a1 to
a437d05
Compare
``` error: dynamic libraries are unsupported for target 'wasm32-unknown-wasip1' [3/15] Linking libIssueReportingTestSupport.wasm ```
so it can be disabled on non-supported platforms, e.g. currently Android
we're importing the Shim now, which should be available in case `#if Combine` resolved to true. It's kind of sad we're leaking
…lerPlugin` not being picked up
I'm not clear why we were seeing:
```/__w/swift-dependencies/swift-dependencies/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift:1:8: error: missing required module 'SwiftCompilerPlugin'
1 | import DependenciesMacrosPlugin
| `- error: missing required module 'SwiftCompilerPlugin'
2 | import MacroTesting
3 | import XCTest
[942/955] Compiling DependenciesMacrosPluginTests BaseTestCase.swift
/__w/swift-dependencies/swift-dependencies/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift:1:8: error: missing required module 'SwiftCompilerPlugin'
1 | import DependenciesMacrosPlugin
| `- error: missing required module 'SwiftCompilerPlugin'
2 | import MacroTesting
3 | import XCTest
[943/955] Compiling DependenciesMacrosPluginTests DependencyEndpointMacroTests.swift
/__w/swift-dependencies/swift-dependencies/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift:1:8: error: missing required module 'SwiftCompilerPlugin'
1 | import DependenciesMacrosPlugin
| `- error: missing required module 'SwiftCompilerPlugin'
2 | import MacroTesting
3 | import XCTest
```
on https://github.com/untitled-in-brackets/swift-dependencies/actions/runs/22952803121/job/66621506036
but hoping being explicit fixes it (and we import, so should be fine?)
Co-authored-by: Stephen Celis <stephen@stephencelis.com>
* feat: group built-in DependencyValues into traits * Apply suggestion from @stephencelis --------- Co-authored-by: Dan Thorpe <dan_thorpe@apple.com> Co-authored-by: Stephen Celis <stephen.celis@gmail.com> Co-authored-by: Stephen Celis <stephen@stephencelis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.