Skip to content

feat(comhub): wire up getMetadata, reactive sync, disconnect stubs, upgrade datex to 0.0.13#87

Merged
jonasstrehle merged 17 commits intorelease/0.0.1from
feature/comhub-runtime-integration
Mar 13, 2026
Merged

feat(comhub): wire up getMetadata, reactive sync, disconnect stubs, upgrade datex to 0.0.13#87
jonasstrehle merged 17 commits intorelease/0.0.1from
feature/comhub-runtime-integration

Conversation

@anmol-virk
Copy link
Collaborator

@anmol-virk anmol-virk commented Mar 9, 2026

Summary #87

Completes the ComHub implementation using the @unyt/datex@0.0.13 runtime APIs.

Changes

  • Upgraded @unyt/datex to 0.0.13 (pinned, no ^)
  • Initialized Runtime.create() in runtime.ts — runtime successfully initializes and returns live ComHub metadata
  • Replaced all hardcoded mock JSON with live Datex.comHub.getMetadata() calls
  • Removed mock fallback data from ComHubOverview.vue and ComHubEndpointView.vue
  • Implemented disconnectSocket and disconnectInterface using Datex.comHub.removeSocket() and Datex.comHub.removeInterface()
  • Reactive syncMetadata() polling every 2s via setInterval, cleared on onUnmounted
  • Improved light/dark mode styling across ComHub views

Testing

  • ComHub view shows live interface data instead of mock
  • Currently shows @@local only — needs server config in defaultConfig to test external connections

Linked Issues

Closes #78
Closes #70
Closes #71
Closes #72
Closes #73
Closes #74

@anmol-virk anmol-virk marked this pull request as ready for review March 9, 2026 22:50
@benStre benStre self-requested a review March 10, 2026 16:08
@benStre benStre changed the base branch from main to release/0.0.1 March 10, 2026 16:09
Copy link
Member

@benStre benStre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already a lot better and seems to work so far, just a few remarks from my side. Can you please ensure that all the issues that are part of this PR are linked in the description of the PR?

@anmol-virk anmol-virk requested a review from benStre March 12, 2026 11:03
@anmol-virk anmol-virk requested a review from benStre March 12, 2026 21:16
@benStre
Copy link
Member

benStre commented Mar 12, 2026

Okay, looks good - just rebase this on release/0.0.1 and make sure to resolve all conflicts - then we can also merge this PR

@anmol-virk anmol-virk force-pushed the feature/comhub-runtime-integration branch from aec25b0 to e725130 Compare March 12, 2026 22:32
@jonasstrehle jonasstrehle merged commit 61c10be into release/0.0.1 Mar 13, 2026
1 check passed
@jonasstrehle jonasstrehle deleted the feature/comhub-runtime-integration branch March 13, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants