Skip to content

Commit

Permalink
Update pnpm to v10 (#266)
Browse files Browse the repository at this point in the history
* Update pnpm to v10

* Fail pnpm install on pnpm v10 ignored build scripts, add missing dep

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Karl Horky <[email protected]>
  • Loading branch information
renovate[bot] and karlhorky authored Feb 10, 2025
1 parent 2e8f85d commit f05f0ac
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/lint-and-check-types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ jobs:
with:
node-version: 'lts/*'
cache: 'pnpm'
- run: pnpm install
- name: Install dependencies
# Fail on pnpm v10 ignored build scripts
#
# TODO: Switch to future `pnpm install` option to fail on pnpm v10 ignored build scripts, if accepted:
# - https://github.com/pnpm/pnpm/issues/9032#issuecomment-2647428724
# run: pnpm install --<flag here>
run: pnpm install | { has_ignored_build_scripts=false; while IFS= read -r line; do echo "$line"; [[ "$line" == *"Ignored build scripts:"* ]] && has_ignored_build_scripts=true; done; [[ "$has_ignored_build_scripts" = false ]]; }

# Fix Renovate running `pnpm install --recursive` causing `version: 'link:'` for eslint-plugin-upleveled
# https://github.com/renovatebot/renovate/discussions/22458
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"devDependencies": {
"@types/node": "22.13.1",
"@typescript-eslint/types": "8.23.0",
"@typescript-eslint/typescript-estree": "8.23.0",
"@typescript-eslint/utils": "8.23.0",
"eslint-config-upleveled": "9.0.0",
"eslint-plugin-upleveled": "2.1.14",
Expand All @@ -30,7 +31,7 @@
"peerDependencies": {
"eslint": "^9.19.0"
},
"packageManager": "pnpm@9.15.4",
"packageManager": "pnpm@10.2.1",
"engines": {
"node": ">=18.0.0"
},
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f05f0ac

Please sign in to comment.