-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of XSS vulnerability #24
Conversation
@dschwarz91 cool, this is a great idea! What do you think about also including:
|
@karlhorky: thx for the feedback!
I've already had an additional example with the deprecated javascrip: URLs, but since there are no really nice fixes for it (at least I dont know about any - besides "stealing" the filter-regex from angular ^^), I decided to just include it in the slides, but not in the example repo. Wasn't aware of the way via "props: " tho - will have a look at that.
good Idea, will add that =)
It absolutely makes sense and I actually already tried to include it in the examples but failed ^^ and it kinda worked (because I could see some trusted types errors in the console), but somehow react seemed to render the page (and also the payload) once before it activated trusted types. |
Maybe some kind of form that submits content to the database which also includes a new But yeah, totally understand if this is outside the scope of this PR - if you think it's too big for now, maybe you can open a new issue for it, with a clear documentation of what needs to be done with this? You may also want to link it to this issue:
Ok I'll wait on this before reviewing again then.
Fine with me, no problem there! Maybe you can open an issue for this too? |
Thanks for this 🙌 I addressed the points above - now merging! |
hey karl,
just added an xss example.
For now, i just put the payload in an additional row in the blog_posts table.
Should we put that in an own table or should we add an additional column to the blog_posts table to somehow mark this entry? What do you prefer?