Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CallQueueTooBigException as a RecoverableException #1

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ asynchbase_SOURCES := \
src/PleaseThrottleException.java \
src/PutRequest.java \
src/QualifierFilter.java \
src/CallQueueTooBigException.java \
src/RecoverableException.java \
src/RegexStringComparator.java \
src/RegionClient.java \
Expand Down
66 changes: 66 additions & 0 deletions src/CallQueueTooBigException.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/*
* Copyright (C) 2010-2012 The Async HBase Authors. All rights reserved.
* This file is part of Async HBase.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
* - Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
* - Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
* - Neither the name of the StumbleUpon nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
package org.hbase.async;

/**
* Exception thrown when we try to use an invalid or expired scanner ID.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste erro ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah very much so copy pasta. Will update this and a formatting error I saw. I'm also verifying this fixes the issues as well.

*/
public final class CallQueueTooBigException extends RecoverableException
implements HasFailedRpcException {

static final String REMOTE_CLASS =
"org.apache.hadoop.hbase.CallQueueTooBigException";

final HBaseRpc failed_rpc;

/**
* Constructor.
* @param msg The message of the exception, potentially with a stack trace.
* @param failed_rpc The RPC that caused this exception, if known, or null.
*/
CallQueueTooBigException(final String msg, final HBaseRpc failed_rpc) {
super(msg + "\nCaused by RPC: " + failed_rpc);
this.failed_rpc = failed_rpc;
}

public HBaseRpc getFailedRpc() {
return failed_rpc;
}

@Override
CallQueueTooBigException make(final Object msg, final HBaseRpc rpc) {
if (msg == this || msg instanceof CallQueueTooBigException) {
final CallQueueTooBigException e = (CallQueueTooBigException) msg;
return new CallQueueTooBigException(e.getMessage(), rpc);
}
return new CallQueueTooBigException(msg.toString(), rpc);
}

private static final long serialVersionUID = -8367228239893289543L;

}

2 changes: 2 additions & 0 deletions src/RegionClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ final class RegionClient extends ReplayingDecoder<VoidEnum> {
new UnknownRowLockException(null, null));
REMOTE_EXCEPTION_TYPES.put(VersionMismatchException.REMOTE_CLASS,
new VersionMismatchException(null, null));
REMOTE_EXCEPTION_TYPES.put(CallQueueTooBigException.REMOTE_CLASS,
new CallQueueTooBigException(null, null));
}

/** We don't know the RPC protocol version of the server yet. */
Expand Down