DX-2352: redis search

[CahidArda]

No description provided.

[linear]

DX-2352 redis-py - redis search implementation

[alitariksahin]

asked for an ai review, comparing with redis-js implementation, can you check

redis-py Search: Missing Features & Bugs

Missing Commands

• SEARCH.AGGREGATE — index.aggregate() method not implemented
• SEARCH.ALIASADD — alias add not implemented
• SEARCH.ALIASDEL — alias delete not implemented
• SEARCH.LISTALIASES — list aliases not implemented

Missing Field Types

• KEYWORD field type missing from FieldType enum in search.py
• FACET field type missing from FieldType enum in search.py

Bugs

• HIGHLIGHT command serialization is broken — highlight["fields"] is passed as a single list element instead of being spread with a count prefix (FIELDS <n> <f1> <f2> ...)
• HIGHLIGHT tags check uses if highlight["tags"]: which raises KeyError when tags is not provided — should be if "tags" in highlight:
• create_index return type annotation is ResponseT but actually returns SearchIndexCommands — breaks type inference
• query filter parameter is required but should be optional to allow match-all queries

Missing Types / Documentation

• No typed filter DSL — $and, $or, $must, $should, $mustNot, $in, $boost operators are untyped and undocumented (they work at runtime since filter is raw JSON, but there's no type support)
• No aggregate types — no AggregateOptions, AggregateResult, or aggregation operator types
• No alias types — no types for alias add/list/delete responses

[CahidArda]

I think you were on an older branch, not all of the things listed were missing.

Made a few small fixes, ready for review

for the filter being not typed: Python isn't as powerful as TS, so we decided to not type filters/aggregations in PY