-
Notifications
You must be signed in to change notification settings - Fork 30
Run tests against running container on travis #132
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm fine with taking out the OS X build.
@gsganden are there particular changes you'd like to be made? PS: Another reason to take out the OSX build: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing |
@gsganden do you need me to review anything on this? |
Nah @jameslamb I can take it. |
ok cool, I'll remove myself from this one. Still happy to hep on this repo if you ever need me! |
it's ok with me if you want to take me out of |
Done |
If you're changing things in the Travis console and then clicking "rebuild", it's possible that that won't work because stuff is cached. I've noticed behavior like that with other CI services before. You could try pushing an empty commit to this branch. I keep this alias in my push_empty (){
git commit --allow-empty -m "empty commit"
git push origin HEAD
} |
Resolves #110 by modifying the travis config to:
Note This doesn't work with the OSX build because
Services are not supported on osx
for travis. However, docker is OS agnostic, so this shouldn't matter. (it's not clear to me what the OSX build is for)To do before/on merging:
AWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
)Pull Request Checklist
dev
branch../.ci/local_checks.sh
passes locally. (The app must be running. SeeREADME.md
for instructions.)Maintainer's responsibilities:
_version.py
has been updated.CHANGELOG.md
has been updated.