Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

Run tests against running container on travis #132

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

davidwilby
Copy link
Contributor

@davidwilby davidwilby commented Oct 27, 2020

Resolves #110 by modifying the travis config to:

  • copying the trained model from AWS,
  • building a local image on travis from the pushed branch,
  • running the two sets of tests.

Note This doesn't work with the OSX build because Services are not supported on osx for travis. However, docker is OS agnostic, so this shouldn't matter. (it's not clear to me what the OSX build is for)

To do before/on merging:

  • add AWS credentials to travis environment variables for repo (AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY)

Pull Request Checklist

  • Pull request has been made against dev branch.
  • Pull request includes a description of the change and the reason behind it.
  • Pull request uses keywords to close relevant issues.
  • Pull request includes unit tests for any new functionality.
  • README and docs have been updated.
  • ./.ci/local_checks.sh passes locally. (The app must be running. See README.md for instructions.)

Maintainer's responsibilities:

  • _version.py has been updated.
  • CHANGELOG.md has been updated.
  • Updated app container has been pushed with current version number.
  • App container version number has been updated everywhere in README.

Copy link
Collaborator

@gsganden gsganden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm fine with taking out the OS X build.

@davidwilby
Copy link
Contributor Author

@gsganden are there particular changes you'd like to be made?
I expect the travis checks to pass once the AWS environment variables for the repo are added on travis and the build re-run.

PS: Another reason to take out the OSX build: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

@jameslamb
Copy link
Collaborator

@gsganden do you need me to review anything on this?

@gsganden
Copy link
Collaborator

gsganden commented Nov 3, 2020

Nah @jameslamb I can take it.

@jameslamb
Copy link
Collaborator

Nah @jameslamb I can take it.

ok cool, I'll remove myself from this one. Still happy to hep on this repo if you ever need me!

@jameslamb jameslamb removed their request for review November 3, 2020 03:25
@jameslamb
Copy link
Collaborator

it's ok with me if you want to take me out of CODEOWNERS and just manually request me when needed

@gsganden
Copy link
Collaborator

gsganden commented Nov 3, 2020

it's ok with me if you want to take me out of CODEOWNERS and just manually request me when needed

Done

@gsganden
Copy link
Collaborator

I believe I added the credentials, but the build isn't finding them. Do you know what to do?

image

@davidwilby
Copy link
Contributor Author

It might be down to one or both of:

  • environment variables being case sensitive:
    image
  • Escaping special characters:
    image

@gsganden
Copy link
Collaborator

gsganden commented Dec 5, 2020

I'm seeing the same error message after changing the variable names to all caps. Any ideas?

image

@jameslamb
Copy link
Collaborator

If you're changing things in the Travis console and then clicking "rebuild", it's possible that that won't work because stuff is cached. I've noticed behavior like that with other CI services before.

You could try pushing an empty commit to this branch. I keep this alias in my ~/.bash_profile for that purpose:

push_empty (){
    git commit --allow-empty -m "empty commit"
    git push origin HEAD
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants