Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.1.0 #18

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Release 2.1.0 #18

merged 5 commits into from
Sep 16, 2024

Conversation

rlepinski
Copy link
Contributor

@rlepinski rlepinski commented Sep 14, 2024 •
edited
Loading

  • Update types
  • Update Android bindings
  • Update iOS bindings

@rlepinski rlepinski requested a review from a team as a code owner September 14, 2024 00:00
@rlepinski rlepinski mentioned this pull request Sep 14, 2024
Closed
crow
crow reviewed Sep 16, 2024
View reviewed changes
ios/Plugin/AirshipPlugin.swift
return nil
}

return try AirshipJSON.wrap(value).decode()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still want this to throw? not just try?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better name? Optional meaning its optionally available, not optionally decodes properly

crow
crow reviewed Sep 16, 2024
View reviewed changes
src/types.ts
logPrivacyLevel: "private" | "public"
}
logPrivacyLevel?: 'private' | 'public';
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this semicolon be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its optional. we set it everywhere else

@rlepinski rlepinski merged commit 3fb9231 into main Sep 16, 2024
1 check passed
@rlepinski rlepinski deleted the release-2.1.0 branch September 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apekka Apekka Apekka approved these changes

@crow crow crow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlepinski @crow @Apekka