fix: Always outputs stdout for running, non-interactive, shells (#427)

* Always outputs stdout for running, non-interactive, shells * outputs all stream info to stderr on error, captures stderr from session * Changes write strategy for non-interactive session --------- Co-authored-by: Blaize Kaye <[email protected]>
uselagoon · Feb 17, 2025 · 2221499 · 2221499
1 parent 5320d38
commit 2221499
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pkg/lagoon/ssh/main.go b/pkg/lagoon/ssh/main.go
@@ -146,12 +146,17 @@ func RunSSHCommand(lagoon map[string]string, sshService string, sshContainer str
 	}
 	var b bytes.Buffer
 	session.Stdout = &b
-
+	var e bytes.Buffer
+	session.Stderr = &e
 	err = session.Run(connString + " " + command)
+
 	if err != nil {
+		os.Stderr.WriteString(b.String())
+		os.Stderr.WriteString(e.String())
 		return err
 	}
-	fmt.Println(b.String())
+	os.Stdout.WriteString(b.String())
+	os.Stderr.WriteString(e.String())
 	return nil
 }