Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import story priority as Priority custom field values #53

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

semperos
Copy link
Member

@semperos semperos commented Apr 8, 2024

The Shortcut Priority Custom Field is enabled in all new workspaces by default.

A previous commit introduced the initialization routines to populate a local data/priorities.csv file that includes a mapping from Pivotal priority to the Priority Custom Field in Shortcut.

This commit leverages that mapping to enhance imported Shortcut Stories with a Priority custom field value.

Pivotal priority p0 through p3 are mapping to the Priority Custom Field Values in Shortcut with positions 0 through 3 (commonly named "Highest", "High", "Medium", and "Low", though users are free to rename them). Pivotal priority of "none" is considered a signal not to set the Priority field in Shortcut at all, so that value is ignored during import.


⭐ For the PR reviewer:

  • I alphabetized a few different lists of names
  • See pivotal_import_test.py to understand the data shapes in play
  • I've tested this against a test Production workspace. You can do the same by running:
    • make clean import to ensure a dry-run works
    • make import-apply to import Stories/Epics/etc.
    • make delete-apply to delete those imported entities

@semperos semperos requested a review from opoku as a code owner April 8, 2024 14:59
Copy link

This pull request has been linked to Shortcut Story #264493: Import story priority.

Copy link

@laurenarnett laurenarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, looking at the tests definitely helped with understanding how the priority_config is being used for translation.

The Shortcut Priority Custom Field is enabled in all new workspaces by
default.

A previous commit introduced the initialization routines to populate a
local data/priorities.csv file that includes a mapping from Pivotal
priority to the Priority Custom Field in Shortcut.

This commit leverages that mapping to enhance imported Shortcut
Stories with a Priority custom field value.

Pivotal priority p0 through p3 are mapping to the Priority Custom
Field Values in Shortcut with positions 0 through 3 (commonly named
"Highest", "High", "Medium", and "Low", though users are free to
rename them). Pivotal priority of "none" is considered a signal not to
set the Priority field in Shortcut at all, so that value is ignored
during import.
@semperos semperos force-pushed the daniel/sc-264493/import-story-priority branch from fe875c2 to 93a94a4 Compare April 8, 2024 16:45
@semperos semperos merged commit d80223e into main Apr 8, 2024
2 checks passed
@semperos semperos deleted the daniel/sc-264493/import-story-priority branch April 8, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants