uucore: fix test_crlf_across_blocks not compiling on Windows - #14254
Open
abhijeetvichare76 wants to merge 1 commit into
Open
uucore: fix test_crlf_across_blocks not compiling on Windows#14254abhijeetvichare76 wants to merge 1 commit into
abhijeetvichare76 wants to merge 1 commit into
Conversation
result() became fallible in 0d335eb, but this Windows-only test still compared the io::Result values directly, and io::Error is not PartialEq. Unwrap both before comparing.
Contributor
|
still draft? |
abhijeetvichare76
marked this pull request as ready for review
August 30, 2026 00:59
Author
|
@xtqqczze just published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo test -p uucoredoes not compile on Windows:result()became fallible in 0d335eb, but this#[cfg(windows)]test still compares theio::Resultvalues directly. CI only builds uucore's lib tests on Linux, so it went unnoticed. Unwrapping both makes the test compile and pass.Note: with this applied,
features::time::tests::test_large_system_time{,_float}then fail on Windows (UNIX_EPOCH + 67768036191763200soverflows a FILETIME). That looks like a separate question about how those tests should behave on Windows, so I left it out of this change.