This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Faster build_newick from pairs instead of ancestry#130
Open
Neclow wants to merge 3 commits into
Open
Conversation
ops::vector: removed unncessary deps ops::newick: rearranged function order benchmarks::core: fixed function names
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Author
|
Worth noting that this "finding" opens up some avenues for simplification. I could imagine having a function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR might be too heavy to include in the next release, as it involves several changes to accelerate newick building.
In essence, new functions are proposed to build a newick string from get_pairs() instead of get_ancestry, thus removing an extra step. Moreover, the new function gets rid of recursion.