Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messages to the script #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add messages to the script #180

wants to merge 1 commit into from

Conversation

Feng-12138
Copy link
Contributor

Notion ticket link

Ticket Name

Implementation description

Steps to test

  1. ./setup_secrets.sh
  2. ./setup_secrets.sh
  3. ./setup_secrets.sh --output_path new_file

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Feng-12138 Feng-12138 requested a review from billcui57 October 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billcui57 billcui57 Awaiting requested review from billcui57

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Feng-12138