Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v 4 lib upgrade #140

Closed
wants to merge 40 commits into from
Closed

Feature/v 4 lib upgrade #140

wants to merge 40 commits into from

Conversation

achen2401
Copy link

@achen2401 achen2401 commented Jan 28, 2022

based on changes from latest release from original AHRQ repo

Changes brought in are:

  • Updated CQL to use latest FHIR 4.0.1 data model (see updated R4 and dstu2 cql files
  • Update CQL execution libraries to latest versions
  • Added support for CQL using VSAC-URL-based value set identifiers (see updated VSAL-URL-based valuset identifiers in Factors_to_Consider_in_Managing_Chronic_Pain_FHIRv401.cql and new VSACAwareCodeService function to extract OID from VSAC URL in executeELM.js
  • Update valueset db JSON (note, I did reconcile the Rxnorm codes for opioid meds that we have added previously with the latest valueset db that is pulled in from the original repo): see new ones added here
  • Add script to allow update of valueset db (see updated README for detail)
  • Add script to update test patients, update Brenda Jackon test json
  • Bumped .node-version to 12.20.0

Changes made as a result of CQL and FHIR version updates:

  • fixed Dispensed date obtained via the extension in a Medication Request FHIR object to be of data type FHIR.date
  • fixed doseQuantity used in a MED calculation to be of data type SimpleQuantity
  • removed LastPositionOf and use Split

Other changes:

  • fix broken tests
  • accessibility updates, i.e. remove unnecessary title attribute from PDF and video links, fixed via running WAVE

@achen2401 achen2401 requested review from ivan-c and pbugni March 7, 2022 18:46
Copy link

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks also for adding and maintaining accurate test code!

README.md Outdated
@@ -8,7 +8,7 @@ The Pain Management Summary SMART on FHIR application was developed to support t

The Pain Management Summary SMART on FHIR application was piloted during Summer 2018. Local modifications and development were needed to fully support this application in the pilot environment. For example, custom development was needed to expose pain assessments via the FHIR API. See the pilot reports for more information.

This application was originally piloted with support for FHIR DSTU2. The app has been updated since the pilot to also support FHIR R4, although pilot R4 support has not been piloted in a clinical setting.
This application was originally piloted with support for FHIR DSTU2. The app has been updated since the pilot to also support FHIR R4, although pilot R4 support has not been piloted in a clinical setting. In addition, value sets and standardized codes have been updated since the pilot. See the comments in the bundled CQL for details.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true?

[...] although pilot R4 support has not been piloted in a clinical setting.

2. Select the ‘Generate new API Key’ checkbox
3. Click ‘Save Profile’
4. Your new API key should now be listed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition, thanks.

@achen2401
Copy link
Author

in favor of #153

@achen2401 achen2401 closed this Feb 9, 2023
@achen2401 achen2401 deleted the feature/v-4-lib-upgrade branch September 14, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants