Skip to content

Failed query poisons the client query cache #1220

Description

@domoritz

The query manager caches the in-flight promise before it settles and never removes it when the query fails. A transient error is then replayed from the cache on every retry.

// a connector that fails once, then succeeds
await coordinator.query('SELECT 1'); // rejects
await coordinator.query('SELECT 1'); // rejects with the same error, connector never called again
  • Likelihood: any transient database or network error on a cached query.
  • Severity: the query keeps failing until the entry expires, three hours by default.

Today the entry-count bound eventually rotates such entries out. #1171 replaces that bound with a byte budget, and a failed entry is charged zero bytes, so nothing evicts it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions