-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC for zip_view implementation, for oneDPL C++20 #1931
Open
MikeDvorskiy
wants to merge
31
commits into
main
Choose a base branch
from
dev/mdvorski/rfc_zip_view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−0
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
09bd199
[oneDPL][rfc][zip_view] + draft
MikeDvorskiy b56c860
Update README.md
MikeDvorskiy 761ecb7
Update README.md
MikeDvorskiy 7ef15f4
Update README.md
MikeDvorskiy e792b5b
Update README.md
MikeDvorskiy 786d5c5
Update README.md
MikeDvorskiy 171e5fe
Update README.md
MikeDvorskiy f9a2e45
[oneDPL][rfc][ranges][zip_view] + Implementation design proposal
MikeDvorskiy 4a701fc
+ spelling fix
MikeDvorskiy cc3eac4
+ spelling fix
MikeDvorskiy 52acfac
+Implementation proposal
MikeDvorskiy 526a603
Delete rfcs/experimental/zip_view/README.md
MikeDvorskiy 518aee0
Update README.md
MikeDvorskiy 234dbdb
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy c20ef9f
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy aec760b
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 9ab570b
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 300e13c
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy f51297e
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 4cade93
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 7b882fb
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 2e9c98d
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 214dcde
Update rfcs/proposed/zip_view/README.md
MikeDvorskiy 1f7b132
Update README.md
MikeDvorskiy 720f1d2
Update README.md
MikeDvorskiy 416010b
Update README.md
MikeDvorskiy 28aed7e
Update README.md
MikeDvorskiy 1ce2407
Update README.md
MikeDvorskiy 20d82e8
Update README.md
MikeDvorskiy 87a32a8
Update README.md
MikeDvorskiy c629dff
Update README.md
MikeDvorskiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Update rfcs/proposed/zip_view/README.md
Co-authored-by: Dmitriy Sobolev <[email protected]>
commit 7b882fbe903d17c23ebad952712a87dda470f7c6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it comes to the specification, this will need to be described as an unspecified tuple which satisfies some set of requirements, unless we want to make the move to specify our internal tuple and make it public (which I doubt we want to do).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of this, I was looking at the specification for our current
zip_iterator
, and noticed a couple of discrepancies as compared to our implementation with regard to std::tuple vs our unspecified internal tuple type. I believe that our implementation is intentional and the "correct" thing here and the spec should be changed, because of issues with device copyability when composing types fromzip_iterators
.std::tuple
is not trivially copyable but our internal tuple is.uxlfoundation/oneAPI-spec#605