-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error aspect fp64 is not supported
in tests of std::complex
#2029
Conversation
Required aspect fp64 is not supported on the device
in tests of std::complex
aspect fp64 is not supported
in tests of std::complex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed offline, I'm not sure how this should help this error. The numeric literals should all be integers, which shouldn't cause problems being confused for doubles. We already seem to protect against testing cases with doubles with our macros, so its only floats that we cast to. These should already be implicitly converting due to constexpr constructor of I see these changes as harmless, but I don't understand how they help either. |
So, I think your new changes will avoid the problem.
However, it effectively just removes any testing of this for devices not supporting |
This is clearly not a proper fix. If the test is supposed to check the use of floats on a device that does not support doubles, obviously the test itself should not use doubles either. If |
6b9a56e
to
6226b4a
Compare
All other significant changes are packed into |
This reverts commit 6226b4a.
…e TestUtils::infinity_val for the float type too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR we fix the error
Required aspect fp64 is not supported on the device
in some tests ofstd::complex
.