cherry pick #2075 #2076
Open
cherry pick #2075 #2076
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akukanov
reviewed
Feb 21, 2025
Comment on lines
+18
to
+19
| Intel, the Intel logo, and Arc are the trademarks of Intel Corporation or its subsidiaries. | ||
|
|
There was a problem hiding this comment.
We already have a very similar claim at the line 10 above. Is it not sufficient?
| @@ -20,7 +20,7 @@ New Features | |||
| with device policies for large data sizes. | |||
| - Improved performance of ``copy``, ``fill``, ``for_each``, ``replace``, ``reverse``, ``rotate``, ``transform`` and 30+ | |||
| other algorithms with device policies on GPUs. | |||
| - Improved oneDPL use with SYCL implementations other than Intel oneDPI DPC++/C++ compiler. | |||
| - Improved oneDPL use with SYCL implementations other than Intel® oneAPI DPC++/C++ Compiler. | |||
There was a problem hiding this comment.
We do not strictly need the trademark symbol here, because the line 7 of the Overview above already contains it, and it's sufficient to do just once for the document.
| sizes of 4-8 million elements. | ||
| - ``sort``, ``stable_sort``, ``sort_by_key`` and ``stable_sort_by_key`` algorithms fail to compile | ||
| when using Clang 17 and earlier versions, as well as compilers based on these versions, | ||
| such as Intel(R) oneAPI DPC++/C++ Compiler 2023.2.0. | ||
| such as Intel® oneAPI DPC++/C++ Compiler 2023.2.0. |
There was a problem hiding this comment.
Similarly here we can just omit the trademark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final cherry pick for release notes.