Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to compile oneTBB without threads #1303

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Conversation

JhaShweta1
Copy link
Contributor

Description

Add a comprehensive description of proposed changes

Fixes # - issue number(s) if exists

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • [X ] new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • [X ] not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

-DEMSCRIPTEN_WITHOUT_PTHREAD = TRUE/FALSE

WASM_Support.md Outdated Show resolved Hide resolved
sarathnandu
sarathnandu previously approved these changes Feb 2, 2024
Copy link
Contributor

@sarathnandu sarathnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

WASM_Support.md Outdated Show resolved Hide resolved
Co-authored-by: Alexandra <[email protected]>
Copy link
Contributor

@dnmokhov dnmokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JhaShweta1 JhaShweta1 merged commit fabaaa6 into master Feb 5, 2024
19 checks passed
@JhaShweta1 JhaShweta1 deleted the dev/shwetajh/wasm_nothread branch February 5, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants