Merge pull request #331 from hvdijk/urkernelretain

urKernelRetain: fix incorrect error result.
uxlfoundation · Feb 2, 2024 · b1d1e75 · b1d1e75
2 parents 50d00b1 + 4cdc7ea
commit b1d1e75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/source/ur/source/kernel.cpp b/source/ur/source/kernel.cpp
@@ -97,7 +97,7 @@ urKernelCreate(ur_program_handle_t hProgram, const char *pKernelName,
 
 UR_APIEXPORT ur_result_t UR_APICALL urKernelRetain(ur_kernel_handle_t hKernel) {
   if (!hKernel) {
-    return UR_RESULT_ERROR_INVALID_NULL_POINTER;
+    return UR_RESULT_ERROR_INVALID_NULL_HANDLE;
   }
   return ur::retain(hKernel);
 }

diff --git a/source/ur/test/source/urKernelRetain.cpp b/source/ur/test/source/urKernelRetain.cpp
@@ -18,6 +18,8 @@
 
 using urKernelRetainTest = uur::KernelTest;
 
+UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urKernelRetainTest);
+
 TEST_P(urKernelRetainTest, Success) {
   ASSERT_SUCCESS(urKernelRetain(kernel));
   EXPECT_SUCCESS(urKernelRelease(kernel));