Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mux] Remove degenerate subgroup support. #646

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

hvdijk
Copy link
Collaborator

@hvdijk hvdijk commented Jan 16, 2025

Overview

[mux] Remove degenerate subgroup support.

Reason for change

Older versions of oneAPI Construction Kit used an implementation of subgroups where the subgroup size was always equal to the workgroup size. This implementation is no longer used by any targets, but the code to support it was still in place. This commit removes it.

Description of change

Describe the intended behaviour your changes are meant to introduce to the
project and explain how they resolve the problem stated above. Detail any
relevant changes that may affect other users of the project, such as
compilation options, runtime flags, expected inputs and outputs, API entry
points, etc.

If you have added new testing, provide details on what tests you have added
and what the purpose of them is.

Anything else we should know?

If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-19 on all modified code.

@hvdijk hvdijk force-pushed the no-degenerate-subgroups branch from 798065c to e5783c3 Compare January 16, 2025 15:34
CHANGELOG.md Outdated Show resolved Hide resolved
@hvdijk hvdijk force-pushed the no-degenerate-subgroups branch 3 times, most recently from a68190f to b0ac1bf Compare January 16, 2025 17:06
Older versions of oneAPI Construction Kit used an implementation of
subgroups where the subgroup size was always equal to the workgroup
size. This implementation is no longer used by any targets, but the code
to support it was still in place. This commit removes it.
@hvdijk hvdijk force-pushed the no-degenerate-subgroups branch from b0ac1bf to 1b4cf39 Compare January 17, 2025 12:27
@hvdijk hvdijk merged commit 00bb1e1 into uxlfoundation:main Jan 17, 2025
13 checks passed
@hvdijk hvdijk deleted the no-degenerate-subgroups branch January 17, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants