Skip to content

Conversation

@cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Oct 21, 2025

What does this PR change?

In order to tune the XML-RPC timeout on the containerized proxy, a new timeout property is read from the config.yaml and stored in the generated rhn.conf. (bsc#1252020)

GUI diff

No difference.

  • DONE

Documentation

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: proxy config

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/28639
Port(s): https://github.com/SUSE/spacewalk/pull/28706

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested a review from a team as a code owner October 21, 2025 14:57
@cbosdo cbosdo requested review from ycedres and removed request for a team October 21, 2025 14:57
@cbosdo cbosdo changed the title Add support for a timeout config of the proxy. Add support for a timeout config of the proxy Oct 21, 2025
meaksh
meaksh previously approved these changes Oct 31, 2025
Copy link
Member

@meaksh meaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbosdo cbosdo changed the base branch from master to master-staging-20251026 October 31, 2025 10:48
@cbosdo cbosdo requested review from a team and cbbayburt as code owners October 31, 2025 10:48
@Etheryte
Copy link
Member

It looks like this pull request might've been incorrectly rebased, please have a look. The diff includes a lot of files that don't like they should be affected.

In order to tune the XML-RPC timeout on the containerized proxy, a new
`timeout` property is read from the config.yaml and stored in the
generated `rhn.conf`. (bsc#1252020)
@cbosdo
Copy link
Contributor Author

cbosdo commented Oct 31, 2025

It looks like this pull request might've been incorrectly rebased, please have a look. The diff includes a lot of files that don't like they should be affected.

changing the base was not enough this time

@cbosdo cbosdo merged commit f83000f into uyuni-project:master-staging-20251026 Oct 31, 2025
22 checks passed
@cbosdo cbosdo deleted the proxy-timeout branch October 31, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants