refactor: improve node topic count parsing with better error handling #115
Conversation
- Rename totalStr to totalCountRaw for better clarity - Add null/empty check before parsing - Use specific NumberFormatException instead of generic Exception - Add error logging for failed parsing attempts - Add descriptive comment explaining the field purpose This is a follow-up to PR #82, implementing improvements suggested by GitHub Copilot review. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the node topic count parsing logic in NodeTopicInfo.java to improve error handling and code clarity. The changes enhance robustness when parsing topic counts from HTML data that may contain formatting like thousand separators.
- Renamed variable for better clarity and added null/empty validation
- Replaced generic exception handling with specific
NumberFormatExceptionhandling - Added error logging for debugging parsing failures
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| @Pick("span.topic-count strong") | ||
| public String totalStr; | ||
| private String totalCountRaw; // Raw topic count string from HTML (may contain thousand separators) |
There was a problem hiding this comment.
The field totalCountRaw is changed from public to private but there's no corresponding public getter method. This could break existing code that directly accesses the field. Consider adding a getter method or maintaining public visibility if external access is needed.
Copilot uses AI. Check for mistakes.
| return Integer.parseInt(totalStr.replaceAll("[^0-9]", "")); | ||
| } catch (Exception e) { | ||
| // Remove thousand separators (commas) and any other non-numeric characters | ||
| String cleanedNumber = totalCountRaw.replaceAll("[^0-9]", ""); |
There was a problem hiding this comment.
If cleanedNumber becomes an empty string after removing all non-numeric characters, Integer.parseInt() will throw a NumberFormatException. Add a check to ensure the cleaned string is not empty before parsing.
| String cleanedNumber = totalCountRaw.replaceAll("[^0-9]", ""); | |
| String cleanedNumber = totalCountRaw.replaceAll("[^0-9]", ""); | |
| if (cleanedNumber.isEmpty()) { | |
| return 0; | |
| } |
Copilot uses AI. Check for mistakes.
Summary
Changes
totalStr→totalCountRawfor better clarity about its purposeNumberFormatExceptioninstead of genericExceptionTesting
Related
🤖 Generated with Claude Code