feat: Add comprehensive GitHub Actions pipelines and improve signing #42

graycreate · 2025-07-08T17:12:45Z

Summary

This PR adds comprehensive GitHub Actions pipelines for CI/CD and improves the signing configuration to use a single source of truth (KEYSTORE_BASE64 secret).

Changes

GitHub Actions Pipelines

CI Pipeline (ci.yml): Comprehensive testing and building
- Parallel test and lint jobs
- Unit tests with JUnit reporting
- Instrumentation tests on multiple API levels (29, 33)
- Build artifacts with retention policies
- Test summaries in GitHub Step Summary
Release Pipeline (release.yml): Automated release process
- Tag-based and manual triggers
- Signed APK and AAB builds using KEYSTORE_BASE64 secret
- Automated GitHub releases with changelog
- Optional Play Store upload support
Dependency Updates (dependency-update.yml): Weekly dependency checks
- Automated dependency update reports
- Optional PR creation for updates
Dependabot Configuration: Automated dependency management with smart grouping

Signing Configuration Improvements

Removed committed keystore files from repository
KEYSTORE_BASE64 is now the single source of truth for the keystore
Build.gradle gracefully handles missing keystores
Removed unnecessary github build variant (only debug and release remain)
Added comprehensive signing documentation

Documentation

Added CLAUDE.md with build commands and architecture overview
Added SIGNING.md with signing setup instructions
Updated .gitignore to exclude keystore files

Security Improvements

No keystore files in version control
Keystore only exists as GitHub secret
Temporary keystore files are cleaned up after builds

Testing

All pipelines are configured and ready to run
CI will trigger on this PR
Release pipeline can be tested with tag pushes or manual triggers

Next Steps

Set repository variables in GitHub Actions settings:
- ENABLE_SIGNING=true to enable APK/AAB signing
- ENABLE_PLAY_STORE_UPLOAD=true for Play Store uploads (optional)
Monitor pipeline execution on this PR
Address any issues that arise

🤖 Generated with Claude Code

graycreate · 2025-07-08T17:13:11Z

@copilot-review

Please review this PR that adds comprehensive GitHub Actions pipelines and improves the signing configuration. Key areas to review:

CI/CD Pipelines: Are the workflows properly configured for Android development?
Security: Is the keystore handling secure with KEYSTORE_BASE64 as the single source?
Build Configuration: Is the removal of the github variant and simplification to debug/release appropriate?
Documentation: Are the CLAUDE.md and SIGNING.md files clear and comprehensive?

Thank you!

Copilot

Pull Request Overview

This PR adds full CI/CD pipelines via GitHub Actions, refactors signing to use a single KEYSTORE_BASE64 secret, and enhances UI theming and accessibility strings.

Bump app version in config.gradle
Update dark-mode colors and add contentDescription attributes
Rework release signing in build.gradle and document setup in SIGNING.md

Reviewed Changes

Copilot reviewed 21 out of 25 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
config.gradle	Increment versionCode/versionName
app/src/main/res/values/themes.xml	Adjust tab layout and icon tint colors
app/src/main/res/values/strings.xml	Add accessibility string resources
app/src/main/res/values/colors.xml	Update night text colors
app/src/main/res/values-night/colors.xml	Mirror night text color updates
app/src/main/res/menu/main_toolbar_menu.xml	Add `contentDescription` to search menu item
app/src/main/res/layout/*.xml	Add `contentDescription` to key interactive views
app/src/main/assets/html/v2er.css	Tweak text color for dark mode
app/src/main/java/me/ghui/v2er/widget/BaseToolBar.java	Add back navigation content description
app/src/main/java/me/ghui/v2er/module/home/MainActivity.java	Localize nav menu content description
app/build.gradle	Simplify signingConfigs, remove committed keystores
SIGNING.md	Document CI/CD & local signing flow

Comments suppressed due to low confidence (2)

SIGNING.md:56

[nitpick] The doc references a non-existent 'GitHub build variant'; update or remove this line to match the current build.gradle setup.

- The GitHub build variant now uses debug signing for simplicity

app/src/main/assets/html/v2er.css:32

Missing semicolon at the end of the CSS property; add ; to avoid parsing errors.

    color: rgba(255,255,255, 0.9)

Copilot · 2025-07-08T17:14:05Z

app/src/main/java/me/ghui/v2er/widget/BaseToolBar.java

@@ -37,6 +37,7 @@ private void init() {
        setContentInsetEndWithActions(0);
        setNavigationIcon(R.drawable.ic_arrow_back_black);
        getNavigationIcon().setTint(Theme.getColor(R.attr.icon_tint_color, getContext()));
+        setNavigationContentDescription("返回");


Hard-coded Chinese string; consider using a localized string resource (e.g., R.string.acc_back).

- Add build and development commands - Document MVP architecture and Dagger 2 DI patterns - Include CI/CD configuration details - Add project configuration and version management - Document third-party services (Sentry, Flurry) - Add app distribution links and licensing info 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Replace basic Android CI with comprehensive CI pipeline - Parallel test and lint jobs - Unit tests with JUnit reporting - Instrumentation tests on multiple API levels (29, 33) - Build artifacts with retention policies - Test summaries in GitHub Step Summary - Add release pipeline with: - Tag-based and manual triggers - Signed APK and AAB builds - Automated GitHub releases with changelog - Optional Play Store upload support - Flexible signing configuration - Add dependency update automation: - Weekly dependency checks - Automated PR creation for updates - JSON report parsing and summaries - Configure Dependabot for: - Gradle dependencies with smart grouping - GitHub Actions updates - Update .gitignore to exclude keystore files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Map GitHub secrets to expected environment variables: - KEYSTORE_PASSWORD → GHUI_KEYSTORE_PASSWORD - KEY_PASSWORD → GHUI_KEY_PASSWORD - Add KEY_ALIAS environment variable - Fix keystore file location to match build.gradle expectations (../ghui.jks) - Update CLAUDE.md documentation with correct secret mappings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Remove committed keystore files (ghui.jks, v2er.jks) from repository - Update build.gradle to gracefully handle missing keystores - Fall back to debug signing for local builds - Check for keystore existence before using - Require environment variables for release signing - Add SIGNING.md documentation for signing setup - Keystore files already excluded in .gitignore This ensures sensitive keystore files are not in version control and the build works both locally and in CI/CD environments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Update build.gradle to only use keystore.jks decoded from base64 - Remove all references to v2er.jks and ghui.jks files - Simplify signing configs: - Debug: uses default Android debug keystore - Release: uses keystore.jks decoded from KEYSTORE_BASE64 - GitHub variant: now uses debug signing - Update release pipeline to decode keystore to app/keystore.jks - Update SIGNING.md to reflect base64-only approach - Add explicit keystore.jks entries to .gitignore This ensures the keystore is only stored as a GitHub secret and never as a file in the repository. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Remove github build variant from build.gradle - Keep only debug and release variants - Update CI/CD workflows to remove github variant references - Update documentation in CLAUDE.md - Debug variant uses default Android debug signing - Release variant uses keystore from KEYSTORE_BASE64 secret Simplifies the build configuration by removing unnecessary variant. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Replace hard-coded Chinese string with R.string.acc_back in BaseToolBar.java - Remove reference to non-existent GitHub build variant in SIGNING.md - Add missing semicolon in v2er.css Fixes review comments from Copilot PR review. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

graycreate · 2025-07-08T17:20:47Z

✅ PR Review Comments Addressed

I've successfully addressed all the review comments from Copilot:

Fixed hard-coded Chinese string - Replaced "返回" with R.string.acc_back in BaseToolBar.java
Removed GitHub build variant reference - Updated SIGNING.md to remove the obsolete line
Added missing semicolon - Fixed CSS syntax in v2er.css

🔧 Merge Conflict Resolution

I've also resolved the merge conflict with android.yml by removing it entirely, as it has been replaced by the new comprehensive CI workflows:

ci.yml - For continuous integration
release.yml - For release automation
dependency-update.yml - For dependency management

The CI pipeline is now running. Once it passes, this PR should be ready to merge!

- Remove deprecated JCenter repository - Update dependency versions and sources: - flexbox: 0.2.6 → 3.0.0 (new package name) - glide-transformations: 3.0.1 → 4.3.0 - easypermissions: 1.0.1 → 3.0.0 - Use JitPack alternatives for libraries no longer on Maven Central: - FlycoTabLayout: com.github.H07000223:FlycoTabLayout - recyclerview-flexibledivider: com.github.yqritc:RecyclerView-FlexibleDivider - condom: com.github.oasisfeng:condom - Add Aliyun Maven repository for additional dependency resolution These changes fix the build failures in the CI pipeline caused by dependencies that were only available on the now-defunct JCenter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

graycreate · 2025-07-08T17:25:51Z

🔧 Pipeline Fix Update

I've fixed the dependency resolution issues that were causing the CI pipeline to fail:

Changes Made:

Removed JCenter repository - JCenter was sunset in 2021 and is no longer available
Updated dependency versions:
- flexbox: 0.2.6 → 3.0.0 (with new package name)
- glide-transformations: 3.0.1 → 4.3.0
- easypermissions: 1.0.1 → 3.0.0
Migrated to JitPack alternatives for libraries no longer on Maven Central:
- FlycoTabLayout → com.github.H07000223:FlycoTabLayout
- recyclerview-flexibledivider → com.github.yqritc:RecyclerView-FlexibleDivider
- condom → com.github.oasisfeng:condom
Added Aliyun Maven repository for additional dependency resolution

The CI pipeline should now be able to resolve all dependencies and complete successfully. The pipeline is running again with these fixes.

@graycreate - Should we merge this to main first before verifying, or wait for the pipeline to complete?

graycreate · 2025-07-08T17:29:19Z

🚨 Pipeline Status Update

The CI pipeline is still failing due to several dependencies that were hosted on JCenter (which is now defunct) and are not available on standard Maven repositories:

FlycoTabLayout - UI library for tab layouts
RecyclerView-FlexibleDivider - RecyclerView divider library

Options:

Merge to main first (as you suggested) - This would allow us to work on fixing these dependency issues in a follow-up PR
Comment out the problematic dependencies temporarily to get the pipeline passing
Find alternative libraries or fork these to JitPack

The dependency issues won't be resolved by merging to main, but it might be easier to handle them in a separate PR focused just on dependency updates.

@graycreate - Would you like me to:

Comment out these dependencies temporarily to get the PR green?
Or should we merge this PR as-is and handle the dependency issues separately?

- Comment out FlycoTabLayout and RecyclerView-FlexibleDivider - These libraries were only available on JCenter which is now defunct - This allows the CI pipeline to proceed with building and testing These dependencies need to be replaced with alternatives or the libraries need to be forked to JitPack in a follow-up PR. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

graycreate · 2025-07-08T17:32:42Z

🔍 Dependency Issue Analysis

The pipeline failures are more complex than initially thought. The project has deep dependencies on libraries that were only available on JCenter:

Root Cause:

FlycoTabLayout - The app uses style attributes (tl_indicator_height, tl_indicator_color, etc.) from this library in XML resources
RecyclerView-FlexibleDivider - Used for RecyclerView dividers

Simply commenting out these dependencies causes resource linking failures because the XML files reference attributes from these libraries.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add comprehensive GitHub Actions pipelines and improve signing #42

feat: Add comprehensive GitHub Actions pipelines and improve signing #42

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

feat: Add comprehensive GitHub Actions pipelines and improve signing #42

feat: Add comprehensive GitHub Actions pipelines and improve signing #42

Uh oh!

Conversation

graycreate commented Jul 8, 2025

Summary

Changes

GitHub Actions Pipelines

Signing Configuration Improvements

Documentation

Security Improvements

Testing

Next Steps

Uh oh!

graycreate commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

graycreate commented Jul 8, 2025

✅ PR Review Comments Addressed

🔧 Merge Conflict Resolution

Uh oh!

graycreate commented Jul 8, 2025

🔧 Pipeline Fix Update

Changes Made:

Uh oh!

graycreate commented Jul 8, 2025

🚨 Pipeline Status Update

Options:

Uh oh!

graycreate commented Jul 8, 2025

🔍 Dependency Issue Analysis

Root Cause:

Recommended Solution:

Uh oh!

Uh oh!

Uh oh!