chore: move feedback item to first position in settings #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move feedback item to first position - Add subtitle showing "唯一反馈渠道" - Update link to https://v2er.app/help 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the settings menu by moving the feedback item to the top position and enhancing it with a subtitle. The feedback URL is also updated from the GitHub issues page to the app's dedicated help page.
- Feedback item moved from middle to first position with enhanced subtitle
- Feedback URL changed from GitHub issues to https://v2er.app/help
- Visual spacing adjustments with
.padding(.top, 8)applied to maintain consistent layout
| Image(systemName: "chevron.right") | ||
| .font(.body.weight(.regular)) | ||
| .foregroundColor(.secondaryText) | ||
| .padding(.trailing, 16) |
There was a problem hiding this comment.
The padding value here is inconsistent with the standard padding used elsewhere in the codebase. According to the SectionItemView.swift implementation, the standard horizontal padding (paddingH) is 15, but this uses 16. This creates visual inconsistency with other SectionView instances like the "关于" section which doesn't specify custom padding and uses the default 15 from the SectionView's content padding.
Suggested change
| .padding(.trailing, 16) | |
| .padding(.trailing, 15) |
Code Coverage Report ❌Current coverage: 30.44% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
🤖 Generated with Claude Code