Skip to content

chore: Improve test stability #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ansku wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Improve test stability #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...readsheet/src/test/java/com/vaadin/addon/spreadsheet/test/demoapps/SpreadsheetDemoUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ public InputStream getStream() {
localeSelect = new NativeSelect<>();
localeSelect.setWidth("200px");
localeSelect.setId("localeSelect");
localeSelect.getDataCommunicator().setMaximumAllowedRows(1000);

final List<Locale> locales = Arrays
.asList(Locale.getAvailableLocales());
Expand Down
7 changes: 6 additions & 1 deletion ...n-spreadsheet/src/test/java/com/vaadin/addon/spreadsheet/test/pageobjects/HeaderPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

import static org.junit.Assert.assertEquals;

import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.support.ui.ExpectedConditions;

import com.vaadin.addon.spreadsheet.test.fixtures.TestFixtures;
import com.vaadin.testbench.TestBenchTestCase;
Expand All @@ -24,7 +26,10 @@ public SpreadsheetPage createNewSpreadsheet() {

public SpreadsheetPage loadFile(String testSheetFilename,
TestBenchTestCase tbtc) {
ComboBoxElement testSheetSelect = $(ComboBoxElement.class).id("testSheetSelect");
waitUntil(ExpectedConditions
.presenceOfElementLocated(By.id("testSheetSelect")));
ComboBoxElement testSheetSelect = $(ComboBoxElement.class)
.id("testSheetSelect");
testSheetSelect.selectByText(testSheetFilename);
testSheetSelect.waitForVaadin();
$(ButtonElement.class).id("update").click();
Expand Down