Skip to content

refactor: register CSS custom property to read its computed value directly #10531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

refactor: register CSS custom property to read its computed value directly #10531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/form-layout/src/layouts/auto-responsive-layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@

/** @private */
get __minWidthLabelsAside() {
const { backgroundPositionY } = getComputedStyle(this.host.$.layout, '::before');
return parseFloat(backgroundPositionY);
return parseFloat(getComputedStyle(this.host).getPropertyValue('--_min-width-labels-aside'));

Check warning on line 175 in packages/form-layout/src/layouts/auto-responsive-layout.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 


See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZql2zqO0aapVAoIfPl7&open=AZql2zqO0aapVAoIfPl7&pullRequest=10531
}

/** @private */
Expand Down
11 changes: 7 additions & 4 deletions packages/form-layout/src/styles/vaadin-form-layout-base-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ import '@vaadin/component-base/src/styles/style-props.js';
import { css } from 'lit';
import { addGlobalThemeStyles } from '@vaadin/vaadin-themable-mixin/register-styles.js';

CSS.registerProperty({
name: '--_min-width-labels-aside',
syntax: '<length>',
inherits: false,
initialValue: '0px',
});

addGlobalThemeStyles(
'vaadin-form-layout-base',
css`
Expand Down Expand Up @@ -132,10 +139,6 @@ export const formLayoutStyles = css`
width: var(--_max-width);
}

:host([auto-responsive]) #layout::before {
background-position-y: var(--_min-width-labels-aside);
}

:host([auto-responsive]) #layout ::slotted(*) {
/* Make form items inherit label position from the layout */
--_form-item-labels-above: inherit;
Expand Down